From: Sebastian Keller Date: Tue, 20 Dec 2022 12:49:59 +0000 (+0100) Subject: overview: Skip SHOWN to SHOWN when changing from app grid to overview X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~22 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f5d793647ba0f813d65241cd53cdc418a9d54498;p=gnome-shell.git overview: Skip SHOWN to SHOWN when changing from app grid to overview Switching between the app grid and the window picker in the overview via gestures results in _gestureEnd() getting called with endProgress !== 0 in both cases, which leads to it calling _showDone(). This then unconditionally changes the state to SHOWN, which in this situation is already the current state. Since the previous commit this results in a warning, so check if we are already in the SHOWN state. Part-of: --- diff --git a/js/ui/overview.js b/js/ui/overview.js index 4966cdb69..4dd59d4ae 100644 --- a/js/ui/overview.js +++ b/js/ui/overview.js @@ -573,7 +573,9 @@ var Overview = class extends Signals.EventEmitter { this._animationInProgress = false; this._coverPane.hide(); - this._changeShownState(OverviewShownState.SHOWN); + if (this._shownState !== OverviewShownState.SHOWN) + this._changeShownState(OverviewShownState.SHOWN); + // Handle any calls to hide* while we were showing if (!this._shown) this._animateNotVisible();